Deprecate wpFunction and wpPassthruFunction #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Documentation
The library already requires version 4.3. There are now a few features of 4.3+ that we have needed in tests, and now in the library itself. Deprecating wpFunction proved to be far too difficult if we were to maintain backwards compatibility with 3.7, so we're updating the requirements to 4.3. We could have done 4.0, but most people using a version < 4.3 are going to be using 3.7 anyway. It's easier to consolidate the version requirements so as to avoid confusion and to decrease the likelihood that our tests will miss an integration issue by not being able to run on the lowest supported version of phpunit.
This will allow a test to fail naturally first (in the tearDown method), then get marked as risky after that.
ericmann
approved these changes
Dec 27, 2016
|
@lkwdwrd bump |
lkwdwrd
approved these changes
Feb 10, 2017
|
@lkwdwrd since this is approved, could you go ahead and merge it? |
stevegrunwell
added a commit
to stevegrunwell/revision-strike
that referenced
this pull request
Feb 26, 2017
…sthruFunction() with passthruFunction(), as the original methods were deprecated. Reference: 10up/wp_mock#78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #18