Fix action failure #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamdharmesh @dkotter @dinhtungdu any concerns merging this in and tagging a minor release to help resolve this for folks running this action? |
iamdharmesh
approved these changes
Nov 9, 2022
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The action has failed multiple times in the recent.
This PR locks the docker image to PHP 7.4 which should be compatible with WPCS release: WordPress/WordPress-Coding-Standards#2035 (comment)
How to test the Change
Tested on a temporary draft PR: https://github.com/10up/simple-podcasting/actions/runs/3428909916/jobs/5713819898
The test failures are correct (since it's not possible to use 10up-Default ruleset with wpcs-action yet)
The annotations work as expected: https://github.com/10up/simple-podcasting/pull/196/files
Changelog Entry
Checklist: