Adds CORS Header to all responses #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `Access-Control-Allow-Origin:*` header to all responses
|
I know someone else suggested this PR-ing this but as noted in #80 (comment) I don’t think this would be a good default for folks. Let’s hold out for the request modifier hook enhancement. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question 1: Should there be default CORS header(s), and if so, what should it be?
Question 2: Instead of default CORS headers, should there be a hook (or other) for configurable response headers?
This PR adds the following header to all responses (untested).
Access-Control-Allow-Origin: *Issue ref: #80