Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 test errors #1

Closed
dmethvin opened this issue Dec 20, 2017 · 2 comments
Closed

Windows 10 test errors #1

dmethvin opened this issue Dec 20, 2017 · 2 comments
Assignees
Labels
bug: windows Issue reported for the Windows environment bug
Milestone

Comments

@dmethvin
Copy link

Looks like the test failures relate to command line, path names, and CR-LF issues. This is Windows 10 with msysgit, perhaps results would be different with Bash on Ubuntu on Windows (WSL)? I'll try to dig into these but if anyone else has time please don't let me slow you down!

$ npm run test

> eleventy-cli@0.1.0 test C:\wamp\www\eleventy
> ava


  107 passed
  7 failed

  TemplateRenderTest » EJS Render Include

  C:\wamp\www\eleventy\test\TemplateRenderTest.js:93

                   nder Include", async t => {
   93:   t.is(path.resolve(undefined, "/included"), "/included");


  Rejected promise returned by test. Reason:

  TypeError {
    message: 'Path must be a string. Received undefined',
  }



  TemplateTest » More advanced getData()

  C:\wamp\www\eleventy\test\TemplateTest.js:146


   146:   t.is(data[cfg.keys.package].name, "eleventy");


  Difference:

  - 'eleventy-cli'
  + 'eleventy'



  TemplateTest » One Layout

  C:\wamp\www\eleventy\test\TemplateTest.js:170



   171:     cleanHtml(await tmpl.renderLayout(tmpl, data)),

  Difference:

    `<div id="layout">
  -   <p>Hello.</p>␍␊
  +   <p>Hello.</p>
    </div>`



  TemplateTest » Two Layouts

  C:\wamp\www\eleventy\test\TemplateTest.js:201



   202:     cleanHtml(await tmpl.renderLayout(tmpl, data)),

  Difference:

    `<div id="layout-b">
      <div id="layout-a">
  -     <p>value2-a</p>␍␊
  -   </div>␍␊
  +     <p>value2-a</p>
  +   </div>
    </div>`



  TemplateDataTest » getData()

  C:\wamp\www\eleventy\test\TemplateDataTest.js:28

   27:   t.is(data.globalData.datakey1, "datavalue1", "simple data value");



  variables, resolve pkg to its value.

  Difference:

  - 'eleventy-cli'
  + 'eleventy'



  TemplateDataTest » addLocalData()

  C:\wamp\www\eleventy\test\TemplateDataTest.js:51

   50:   t.is(data.globalData.datakey1, "datavalue1");
    1:   t.is(data.globalData.datakey2, "eleventy");


  Difference:

  - 'eleventy-cli'
  + 'eleventy'



  TemplateDataTest » addLocalData() doesn’t exist but doesn’t fail

  C:\wamp\www\eleventy\test\TemplateDataTest.js:70

         t.is(withLocalData.globalData.datakey1, "datavalue1");
          .is(withLocalData.globalData.datakey2, "eleventy");
   71:   t.deepEqual(Object.keys(withLocalData), beforeDataKeyCount);

  Difference:

  - 'eleventy-cli'
  + 'eleventy'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! eleventy-cli@0.1.0 test: `ava`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the eleventy-cli@0.1.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
@zachleat
Copy link
Member

Thanks @dmethvin!

@zachleat
Copy link
Member

The picture may be even better. I had to rename my package.json name for npm publish and broke 4 tests. So, I’m guessing only 3 failing tests here now.

@zachleat zachleat added the bug label Dec 21, 2017
@zachleat zachleat self-assigned this Mar 29, 2018
@zachleat zachleat added the bug: windows Issue reported for the Windows environment label Mar 29, 2018
@zachleat zachleat added this to the v0.3.1 milestone Mar 29, 2018
zachleat pushed a commit that referenced this issue Sep 19, 2019
zachleat pushed a commit that referenced this issue Sep 8, 2020
mwaldrich added a commit to ProfilingPromisesBenchmarks/eleventy that referenced this issue Aug 22, 2021
franktip added a commit to ProfilingPromisesBenchmarks/eleventy that referenced this issue Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: windows Issue reported for the Windows environment bug
Projects
None yet
Development

No branches or pull requests

2 participants