Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes for setLiquidOptions in 1.0 #1390

Closed
zachleat opened this issue Sep 4, 2020 · 3 comments
Closed

Breaking changes for setLiquidOptions in 1.0 #1390

zachleat opened this issue Sep 4, 2020 · 3 comments

Comments

@zachleat
Copy link
Member

zachleat commented Sep 4, 2020

Because the major version of Liquid changed, there might be breaking changes here for those using setLiquidOptions. Specifically:

+1 to shimming "strict_filters" to "strictFilters" when bumping up to liquidjs v9 (so that both are supported and we don't break anything).

via @pdehaan in #469 (comment)

(note that we have strict_filters examples in the docs too)

I’m leaning towards not shimming these per the 1.0 release—but we should at least add a console warning and list them in the migration guide (and update the docs too).

@zachleat
Copy link
Member Author

zachleat commented Sep 8, 2020

Further complicating this, we changed the default value too for 1.0: #222

@zachleat
Copy link
Member Author

Code merged for this into the https://github.com/11ty/eleventy-upgrade-help plugin

zachleat added a commit to 11ty/11ty-website that referenced this issue Jul 10, 2021
@zachleat
Copy link
Member Author

Docs updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant