Throw an error if includes or data directory is outside of Eleventy’s working directory #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the first step for #368.
Makes
TemplateConfig
throw an error on construction if either the includes or data directories point outside of Eleventy’s working directory.There is also some unrelated clean up in the first commit:
The
TemplateWriter
class no longer creates itsEleventyFiles
object itself when it is missing. This was only there to ensure that theEleventyFiles
object is set during testing. Setting it is now a responsibility of the tests itself.What do you think about the error message or error handling in general?
Note: Since there might be users who rely on the current functionality, this is a breaking change.