Add JSDoc Comments for Config and TemplateConfig. Adjust references #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zachleat Anything blocking this? It is lying around for a month now. |
What's needed for a retrigger, @zachleat? The only failing test („Reset Benchmark”) seems unrelated. |
|
I know this is old and low prioritiy, but I’d like to say 👍 to this. Even fairly minimal JSDoc comments are helpful! |
|
Merged thank you! |
|
I already lost hope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zachleat,
today is bank holiday in my country so I took some time to ad moar JSDoc strings :-)
If you are fine with, I'd submit those additions in small chunks of like 100 lines of code each (to ease the review).
Cheers
Ryuno-Ki