Does not recognize enum definitions starting with "_"

[AMiniLegend]

Enum definition "_undefined = 0;" caused an issue with the lexer (error printout: "Did not parse all of file"). Removing the underscore fixed the problem.

[hadrielk]

Hmmm... according to the google protobuf language spec (https://developers.google.com/protocol-buffers/docs/reference/proto2-spec), a leading underscore is not valid for an enumerator name. It has to be a lower-case or upper-case letter for the first character. No?

But I suppose this wireshark plugin doesn't need to be so pedantic. (and even if it is, it should print out better error info)

[AMiniLegend]

That makes sense. I'm using a third-party's proto files, so they probably
didn't bother to standardize. It was an easy change to remove the
underscores for it to work.

Either decision is fine by me, but I agree that a better description may be
helpful. It may save others with similar issues in the future.

On Mon, Apr 25, 2016 at 2:31 PM, Hadriel Kaplan notifications@github.com
wrote:

Hmmm... according to the google protobuf language spec (
https://developers.google.com/protocol-buffers/docs/reference/proto2-spec),
a leading underscore is not valid for an enumerator name. It has to be a
lower-case or upper-case letter for the first character. No?

But I suppose this wireshark plugin doesn't need to be so pedantic. (and
even if it is, it should print out better error info)

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1 (comment)