Add support so subsitutions can use JsonPath #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlythMeister
force-pushed
the
jsonpath
branch
3 times, most recently
from
a3a0e28
to
f70bca7
Compare
BlythMeister
force-pushed
the
jsonpath
branch
from
cf08bb0
to
3822d88
Compare
| <Root xmlns="http://15below.com/Substitutions.xsd"> | ||
| <Namespaces /> | ||
| <Files> | ||
| <File Filename="TestUpdateFiles\TestJson01.json" FileType="JSON"> |
There was a problem hiding this comment.
Could we make the FileType parameter optional - i.e. if the file extension ends with .json then it's implied anyway?
| <Changes> | ||
| <Change type="ChangeValue" jsonPath="$.Data" value="NewData" /> | ||
| <Change type="ChangeValue" jsonPath="$.SubTrees.DataPoint.Value" value="Bill" /> | ||
| <Change type="ReplacementContent" jsonPath="$.Collection"> |
There was a problem hiding this comment.
Is there anything fundamentally different between "ChangeValue" and "ReplacementContent"?
Apart from the fact that one allows you to enter a CDATA section? Could this potentially be merged into one operation? E.g. using either a value attribute or a node?
This is because replacement content and change value were doing pretty much the same thing!
|
@richard-green changes made as requested |
richard-green
suggested changes
Sep 16, 2019
| <Reference Include="Microsoft.CSharp" /> | ||
| <Reference Include="Newtonsoft.Json, Version=12.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL"> | ||
| <SpecificVersion>False</SpecificVersion> | ||
| <HintPath>..\..\packages\Newtonsoft.Json\lib\net45\Newtonsoft.Json.dll</HintPath> |
There was a problem hiding this comment.
I think this should be a paket reference?
src/Ensconce.Update/UpdateFile.cs
Outdated
| { | ||
| Logging.Log($"Updating JsonPath {sub.Path}"); | ||
|
|
||
| var xPathMatches = baseJson.SelectTokens(sub.Path.RenderTemplate(tagValues)).ToList(); |
src/Ensconce.Update/UpdateFile.cs
Outdated
|
|
||
| if (!sub.PathMatchAll && xPathMatches.Count > 1) | ||
| { | ||
| throw new ApplicationException($"JsonPath select of {sub.Path} returned multiple matches. If the intention was to update all matches, use the attribute matchAll=\"true\" on the XPath or Change node."); |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the standard subsitution files to update JSON rather than XML.
This will only support ChangeValue & ReplacementContent (for now)
Adding new and add child content are out of scope for now.