files: avoid surprises when linking files (nix-community#3018)

15cm · Feb 9, 2023 · 9a77f0a · 9a77f0a
1 parent be025cb
commit 9a77f0a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/modules/files.nix b/modules/files.nix
@@ -185,8 +185,9 @@ in
               $VERBOSE_ECHO "Skipping '$targetPath' as it is identical to '$sourcePath'"
             else
               # Place that symlink, --force
+              # This can still fail if the target is a directory, in which case we bail out.
               $DRY_RUN_CMD mkdir -p $VERBOSE_ARG "$(dirname "$targetPath")"
-              $DRY_RUN_CMD ln -nsf $VERBOSE_ARG "$sourcePath" "$targetPath"
+              $DRY_RUN_CMD ln -Tsf $VERBOSE_ARG "$sourcePath" "$targetPath" || exit 1
             fi
           done
         '';