Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APP-31602] apply catch exception with deleting channel #12

Closed
wants to merge 1 commit into from
Closed

[APP-31602] apply catch exception with deleting channel #12

wants to merge 1 commit into from

Conversation

teresayen
Copy link

apply catch exception with deleting channel
https://github.com/17media/OneSignal-Android-SDK/pull/3/files

also remove the NullPointerException error handling according to the issue which is fixed in version 4.3.1

@AlanChienYL
Copy link

這個好像可以不用做了？看起來他們有把他包起來

@teresayen
Copy link
Author

我以為要包的是 deleteNotificationChannel 的部分，所以才做調整
原本看起來只有包到 getNotificationChannels

@teresayen
Copy link
Author

NPE 是在 getNotificationChannel 裡

@teresayen teresayen closed this Jan 4, 2022
@teresayen teresayen reopened this Jan 4, 2022
@teresayen teresayen added the wontfix This will not be worked on label Jan 4, 2022
@teresayen teresayen closed this Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanChienYL AlanChienYL Awaiting requested review from AlanChienYL

@kentsung118 kentsung118 Awaiting requested review from kentsung118

@ZackCLT ZackCLT Awaiting requested review from ZackCLT

@ZellHo ZellHo Awaiting requested review from ZellHo

Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
2 participants
@teresayen @AlanChienYL