Fix author bug #2010
Merged
Fix author bug #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemfarmer
force-pushed
the
debug-author
branch
from
f945a28
to
159e497
Compare
|
@coreycaitlin @jamiealbrecht Did this fix the bug for either of you? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making the PR to
masterbecause the bug is only on masterFixes issue(s) #2009
馃槑 PREVIEW
Changes proposed in this pull request:
It is hard to be 100% certain that this change will fix the bug seen in #2009, but I'm confident that it will. I think that the issue that we were seeing here is that URLs in production are constructed by combining a site
urlwith a sitebaseurl. It is assumed thatbaseurlis an empty string, as we set it in _config.yml, but Federalist may be updating it.In this set of changes I'm
baseurlstringsite/18F/18f.gsa.gov""/cc @coreycaitlin