Dev --> Master #2142
Merged
Dev --> Master #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Install accesslint-ci and accesslint-cli. - Update _config-blog.yml by running `ruby config_blog.rb`. - Define a `serve-accesslint` script. - Use config-blog.yml to only serve the 3 most recent posts. - Compare errors with the most recent successful build of `dev` branch.
Serve accesslint
Handle author with no blog posts
Blog search filtering
Removed anti-aliasing from body
houndci-bot
reviewed
Dec 20, 2016
| module SiteData | ||
| class AuthorData | ||
| def initialize | ||
| @path = File.join(Dir.pwd, "_authors") |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
houndci-bot
reviewed
Dec 20, 2016
| if x.data['name'].nil? | ||
| puts "No such author: #{input} in #{x}" | ||
| else | ||
| x.data['name'].downcase == input.downcase |
There was a problem hiding this comment.
Use casecmp instead of downcase ==.
|
I found 4 accessibility errors: |
houndci-bot
reviewed
Dec 20, 2016
| @path = File.join(Dir.pwd, '_authors') | ||
| end | ||
|
|
||
| def update(author_file, key, value) |
There was a problem hiding this comment.
Assignment Branch Condition size for update is too high. [16.28/15]
Method has too many lines. [14/10]
There was a problem hiding this comment.
The alternative was also problematic !
|
I found 3 accessibility errors: |
|
One small change and then this should be good to ship! Making a PR now |
|
Actually, nevermind @coreycaitlin. I was looking at the wrong branch. This looks good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃槑 PREVIEW
Changes proposed in this pull request:
/cc @gemfarmer @elainekamlley