[GH-1264] Address PO feedback

- Update historical data download page header copy - Re-add definitions link on data downloads page
18F · May 23, 2024 · 487a2e4 · 487a2e4
1 parent f39af7d
commit 487a2e4
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 33 deletions.
diff --git a/assets/bundle.js b/assets/bundle.js
diff --git a/js/components/data_downloads/DataDownloads.js b/js/components/data_downloads/DataDownloads.js
@@ -24,6 +24,7 @@ function DataDownloads({ dataURL, dataPrefix }) {
         <table className="usa-table usa-table--borderless desktop:grid-col-8">
           <caption>
             <h2>User traffic reports</h2>
+            <a href="/definitions">See data fields and metrics descriptions</a>
           </caption>
           <thead>
             <tr>

diff --git a/js/components/data_downloads/__tests__/__snapshots__/DataDownloads.spec.js.snap b/js/components/data_downloads/__tests__/__snapshots__/DataDownloads.spec.js.snap
@@ -12,6 +12,11 @@ exports[`DataDownloads renders 1`] = `
         <h2>
           User traffic reports
         </h2>
+        <a
+          href="/definitions"
+        >
+          See data fields and metrics descriptions
+        </a>
       </caption>
       <thead>
         <tr>

diff --git a/js/components/historical_data_download/HistoricalDataDownload.js b/js/components/historical_data_download/HistoricalDataDownload.js
@@ -234,27 +234,16 @@ function HistoricalDataDownloads({ apiURL, mainAgencyName, agencies }) {
               those years, so the yearly analysis represents a different sample
               size of participating websites.
             </p>
-            <p>
-              This directional information should only be used for general
-              insights into online visitor behavior trends.
-            </p>
-            <h2>
-              <svg
-                className="usa-icon"
-                aria-hidden="false"
-                focusable="false"
-                role="img"
-              >
-                <use xlinkHref="/assets/uswds/img/sprite.svg#warning"></use>
-              </svg>
-              <span>A note on sampling</span>
-            </h2>
             <p>
               Due to varying Google Analytics API sampling thresholds, and the
               sheer volume of data in the Digital Analytics Program Universal
               Analytics property, reports are subject to sampling. The data are
               intended to represent trends and numbers may not be precise.
             </p>
+            <p>
+              This directional information should only be used for general
+              insights into online visitor behavior trends.
+            </p>
           </div>
         </div>
 

diff --git a/...ents/historical_data_download/__tests__/__snapshots__/HistoricalDataDownload.spec.js.snap b/...ents/historical_data_download/__tests__/__snapshots__/HistoricalDataDownload.spec.js.snap
@@ -32,25 +32,10 @@ exports[`HistoricalDataDownload renders 1`] = `
         These Universal Analytics historical reports represent only summary-level web traffic and user demographic data aggregated by month and calendar year between January 1, 2018 and June 30, 2024. The data is limited to DAP-participating, public-facing federal government websites at the time of the original data collection. The number of websites participating in DAP was increasing during those years, so the yearly analysis represents a different sample size of participating websites.
       </p>
       <p>
-        This directional information should only be used for general insights into online visitor behavior trends.
+        Due to varying Google Analytics API sampling thresholds, and the sheer volume of data in the Digital Analytics Program Universal Analytics property, reports are subject to sampling. The data are intended to represent trends and numbers may not be precise.
       </p>
-      <h2>
-        <svg
-          aria-hidden="false"
-          className="usa-icon"
-          focusable="false"
-          role="img"
-        >
-          <use
-            xlinkHref="/assets/uswds/img/sprite.svg#warning"
-          />
-        </svg>
-        <span>
-          A note on sampling
-        </span>
-      </h2>
       <p>
-        Due to varying Google Analytics API sampling thresholds, and the sheer volume of data in the Digital Analytics Program Universal Analytics property, reports are subject to sampling. The data are intended to represent trends and numbers may not be precise.
+        This directional information should only be used for general insights into online visitor behavior trends.
       </p>
     </div>
   </div>