Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicative server reloads caused by DNS changes #191

Closed
GUI opened this issue Feb 25, 2015 · 1 comment
Closed

Fix duplicative server reloads caused by DNS changes #191

GUI opened this issue Feb 25, 2015 · 1 comment

Comments

@GUI
Copy link
Member

GUI commented Feb 25, 2015

In light of the recent changes to how we handle backend domain DNS changes (see #131), we now reload nginx whenever we detect a DNS change. Since we rolled that feature out, it's been working, but while debugging #188, I discovered that we were actually reloading nginx more frequently than we needed to. Basically, we were performing duplicate DNS queries in some scenarios, and in other race conditions we could send two reload commands in quick succession. This wasn't necessarily causing issues, but it was causing unnecessary reload churn on the server, which isn't ideal.

@GUI GUI added this to the Sprint 16 (2/23-3/6) milestone Feb 25, 2015
@GUI GUI self-assigned this Feb 25, 2015
@GUI
Copy link
Member Author

GUI commented Feb 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant