Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another rate limiting corner case with custom rate limit settings #202

Closed
GUI opened this issue Mar 19, 2015 · 1 comment
Closed

Fix another rate limiting corner case with custom rate limit settings #202

GUI opened this issue Mar 19, 2015 · 1 comment

Comments

@GUI
Copy link
Member

GUI commented Mar 19, 2015

There was another rate limiting edge case bug similar to the issue we identified yesterday in #201. This one came thanks to an open source user of API Umbrella in NREL/api-umbrella#127

Basically, the bug only occurred when the following steps were taken:

  • An admin edits a user and assigns a custom rate limit to the user. The admin saves the user.
  • The admin then edits the user and removes each custom rate limit explicitly, but keeps the rate limit mode still as "custom" (if the admin just flips the rate limit back to "default", then this problem doesn't occur). The admin then hits save.

In this case, that specific api key essentially has it's rate limits removed, which obviously isn't good. Also un-intuitively, even if the admin then flips this user back to have "default" rate limits, the problem still persists once the user is saved in this state.

Luckily, I don't think this sequence of steps in the admin has been very common. There was only one api key in our database with this setup, but that user hasn't actually been active.

@GUI GUI self-assigned this Mar 19, 2015
@GUI GUI added this to the Sprint 17 (3/9-3/20) milestone Mar 19, 2015
@GUI
Copy link
Member Author

GUI commented Mar 19, 2015

Fixed and test coverage added by this commit: NREL/api-umbrella-gatekeeper@6785c60

@GUI GUI closed this as completed Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant