Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging of all HTTPS requests as HTTP in analytics #208

Closed
GUI opened this issue Mar 26, 2015 · 1 comment
Closed

Fix logging of all HTTPS requests as HTTP in analytics #208

GUI opened this issue Mar 26, 2015 · 1 comment

Comments

@GUI
Copy link
Member

GUI commented Mar 26, 2015

While investigating overall HTTPS usage as part of #34, I discovered that during the API Umbrella v0.7 upgrade we rolled out in February (#180), our analytics stopped properly logging whether a request was made via HTTP or HTTPS. Instead, everything since February 9 has unfortunately been logging as HTTP, even if the request was actually made via HTTPS.

How we collect this information for analytics logging changed quite a bit in that v0.7 release, and it looks like this specific bit bit information was no longer being collected properly. Unfortunately, we can't really fix the past couple months worth of logging, but it would be good to fix this going forward. And for historical purposes, we at least have this information prior to February 7, so we we still have a pretty good idea of overall HTTP vs HTTPS traffic trends.

@GUI GUI self-assigned this Mar 26, 2015
@GUI GUI added this to the Sprint 18 (3/23-4/3) milestone Mar 26, 2015
@GUI
Copy link
Member Author

GUI commented Mar 26, 2015

Fixed by NREL/api-umbrella-router@b989713 and tests added to our integration suite around this logging behavior to help ensure this doesn't break again.

@GUI GUI closed this as completed Mar 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant