Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin API Drilldown chart not taking time zone into account #217

Closed
GUI opened this issue Apr 26, 2015 · 1 comment
Closed

Admin API Drilldown chart not taking time zone into account #217

GUI opened this issue Apr 26, 2015 · 1 comment

Comments

@GUI
Copy link
Member

GUI commented Apr 26, 2015

In the admin analytics charts, we are supposed to be taking into account the time zone of the user when displaying the results by day. We do this properly in the "Filter Logs" charts, but not in the "API Drilldown" charts. This can lead to slightly confusing results when comparing the results between the two areas, since the totals between days won't match up. We should ensure that we're also taking into account the user's time zone for the API Drilldown charts too.

Here's an example of how the problem can present itself when comparing a query in the "Filter Logs" chart:
screen shot 2015-04-26 at 11 22 42 am

And here's the same query under the "API Drilldown" chart:
screen shot 2015-04-26 at 11 22 53 am

The totals are the same, but in the "Filter Logs" chart, due to when the requests are made, the total for Tuesday is 2 requests, and the total for Wednesday is 1 request. In the "API Drilldown" chart, the total for Tuesday is 0 requests, and the total for Wednesday is 3 requests.

@GUI GUI added the bug label Apr 26, 2015
@GUI GUI self-assigned this Apr 26, 2015
@GUI GUI added this to the Sprint 20 (4/20-5/1) milestone Apr 26, 2015
@GUI
Copy link
Member Author

GUI commented Apr 26, 2015

Fixed in NREL/api-umbrella-web@981e31d The example query above now reports the same daily totals between the "Filter Logs" chart and the "API Drilldown" chart.

@GUI GUI closed this as completed Apr 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant