This repository has been archived by the owner on Sep 12, 2019. It is now read-only.
Add ability to use npm through docker-compose #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmc333333
approved these changes
Jul 26, 2017
| - $PWD:/usr/src/app | ||
| - npm_libs:/usr/src/app/frontend_build/node_modules/ | ||
| working_dir: /usr/src/app/frontend_build/ | ||
| entrypoint: ../devops/deps_ok_then npm |
There was a problem hiding this comment.
NBD, but one potential improvement would be to remove the duplication with YAML references. It'd look something like:
grunt: &NODE
image: node:6
...
npm:
<<: *NODE
entrypoint: ../devops/deps_ok_then npmThere was a problem hiding this comment.
This PR is sitting here because I want to implement this before merging. If you think I should just merge, lmk.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to do things like
docker-compose run npm install.