More Circle CI testing #518
Conversation
| command: | | ||
| docker create -v /usr/src/app -v /usr/src/app/.venv --name holder python:3.6.2 | ||
| docker cp . holder:/usr/src/app | ||
| docker start holder |
There was a problem hiding this comment.
Very innovative solution, nice work!
.circleci/config.yml
Outdated
| - run: | ||
| name: run tests | ||
| command: | | ||
| ls eregs_libs |
.circleci/config.yml
Outdated
| ls eregs_libs | ||
| docker-compose -f docker-compose-circle.yml run flake8 atf_eregs | ||
| docker-compose -f docker-compose-circle.yml run py.test atf_eregs/tests | ||
| environment: |
There was a problem hiding this comment.
Not needed this time through, but we should figure out how to run the parser tests, too.
.circleci/config.yml
Outdated
| docker-compose -f docker-compose-circle.yml run flake8 atf_eregs | ||
| docker-compose -f docker-compose-circle.yml run py.test atf_eregs/tests | ||
| environment: | ||
| DEBUG: TRUE |
There was a problem hiding this comment.
Is this needed? I think the docker-compose file is setting the DEBUG value in its containers.
| @@ -13,14 +13,14 @@ if [ -n "$DEBUG" ]; then | |||
|
|
|||
| if git diff --exit-code eregs_libs/regulations-site > /dev/null | |||
| then | |||
| git submodule update eregs_libs/regulations-site | |||
| git submodule update --init eregs_libs/regulations-site | |||
There was a problem hiding this comment.
The --init was added in #494 -- does this need to be rebased, maybe?
| persistent_db: | ||
| image: postgres:9.4 | ||
| volumes_from: | ||
| - container:holder |
There was a problem hiding this comment.
Not for this round, but if the volumes are the only significant change, what do you think about replacing them in a sed command or similar? That way we wouldn't need to maintain two configurations.
docker-compose.yml
Outdated
| entrypoint: ls | ||
| command: '' | ||
| ports: [] | ||
|
|
There was a problem hiding this comment.
I'm betting this addition wasn't intended?
|
@cmc333333 Thanks for the comments, there's a bunch of stuff in here that's not final—I had meant to label this I was trying to not maintain two configurations by using docker-compose's I'll rebase before a final PR, as we definitely don't need tens of identical commit messages… |
|
I moved the rebased commits into another branch and made a new PR. Closing. |
This is a prior version of the config that worked, and I'm breaking it out into its own branch for more testing.