Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

[WIP] Testing docs, JS lint, more tests? #1446

Closed
wants to merge 12 commits into from
Closed

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented May 27, 2016

  • Add a test/data README.
  • Clean up our JS so that it doesn't generate any errors when you run npm run lint-js.
  • Remove some old/unused scripts.
  • Switch to ESLint?
  • Stub out some new tests for other data?

@gemfarmer
Copy link
Contributor

Some other possible testy things

  • add lint-js to circle.yml config
  • add test-html to circle tests. First ensure that all tests pass!

@shawnbot
Copy link
Contributor Author

shawnbot commented May 28, 2016

I'm on the fence about adding lint-js (or lint-scss) to the CI config, unless we're planning on removing @houndci. The question is: Do we prefer the CI build to fail if we push code that doesn't meet the conventions, or do we want to continue be hounded in the pull request comments? My gut reaction is that having the builds fail outright seems a little extreme.

Also, we should try out the new ESLint setup referenced in 18F/frontend#98.

@shawnbot
Copy link
Contributor Author

Also, there are lots of errors in lint-html. 😬 I'm not sure how many of them are valid, but we'll probably need to push that off into a separate issue.

@gemfarmer
Copy link
Contributor

I would also prefer hound! Fine with pushing off lint-html til later.

@gemfarmer
Copy link
Contributor

gemfarmer commented May 31, 2016

Thoughts on adding an accessibility check to Circle? This could also be pushed off to a new issue.

@shawnbot shawnbot closed this Sep 12, 2016
@coreycaitlin coreycaitlin deleted the test-all-things branch November 2, 2017 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants