Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Update Gulp Task - Recommended #29

Closed
4 tasks done
lauraGgit opened this issue Aug 8, 2016 · 3 comments
Closed
4 tasks done

Update Gulp Task - Recommended #29

lauraGgit opened this issue Aug 8, 2016 · 3 comments

Comments

@lauraGgit
Copy link

lauraGgit commented Aug 8, 2016

To improve load performance of the production site we recommend that you alter a number of the tasks performed in the npm run package gulp script.

  • Minify CSS for the build/dest
  • Bundle the js libs into the minified fedramp.min.js in build/dest. This would make it so you wouldn't need the separate lib, build/lib, or build/dest/lib directories and would then only require the site to load 1 js file.
  • Change the copy fonts, img task to just copy these directories from the node_modules/uswds/dist directories. Then remove the directories from the committed repository.
  • When the npm run package is run do not copy unminified fedramp.js to build/dest
@bmallred
Copy link
Contributor

bmallred commented Aug 9, 2016

So we went ahead and made another command npm run build to keep the unminified sources. This is necessary so the in-browser test and coverage suites can still operate.

@lauraGgit
Copy link
Author

Liking the

  • minified css
  • fully bundled JS
  • directly copying the fonts/ uswds assets
  • updated gulp tasks

@lauraGgit
Copy link
Author

Also, the newly built dist folder seems to deploy correctly to the AWS bucket.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants