Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visually compare migrated guides against existing guides #167

Closed
8 tasks done
Tracked by #156
christophermather opened this issue Nov 14, 2023 · 1 comment
Closed
8 tasks done
Tracked by #156

Visually compare migrated guides against existing guides #167

christophermather opened this issue Nov 14, 2023 · 1 comment
Assignees
Labels
Guides Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods"

Comments

@christophermather
Copy link

christophermather commented Nov 14, 2023

A description of the work

This is part of step 1 in the 18F guide to migrating a guide. This task follows #157.

As a final step before starting migration steps, we need to visually compare migrated guides against existing guides to do a final validation pass that they are ready to migrate.

Ready for review

Based on completed tasks from #157

Point of contact on this issue

@christophermather

Our evaluation rubric

Parity not perfection!

We want to make sure that we're not losing any functionality. If we come across any errors or problems that exist on both sites, we should log them in our tracker spreadsheet. We will add them to the backlog and address post-migration.

Reproduction steps

This will involve a manual click-through of sites. Meaning:

  1. Pull up the replatformed guide URL in one window
  2. Pull up the corresponding existing guide URL in another
  3. Scan each page for visual similarity/uniformity
  4. Make note of any (significant) discrepancies. You can add these discrepancies to this tracker spreadsheet.
  5. If no discrepancies, mark that guide as complete in task list below
  6. If discrepancies, review w/ @christophermather and add issues to the backlog

Skills Needed

  • Any Human
  • Design
  • Content
  • Engineering
  • Engineering Hiring
  • Acquisition
  • Product
  • Other

Does this need to happen in the next 2 weeks?

  • Yes
  • No

How much time do you anticipate this work taking?

No response

Acceptance Criteria

  • All replatformed guides have been checked against the existing guides
  • Guides that are ready are given the greenlight
  • Guides that have any discrepancies have been flagged as blocked and discrepancies have been turned into issues in the backlog

Tasks

@christophermather christophermather added Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods" Guides labels Nov 14, 2023
@a-chappelear a-chappelear self-assigned this Nov 15, 2023
@christophermather
Copy link
Author

Confirming that the visual comparisons are done, we've logged discrepancies, verified that certain design changes were intentional, flagged a couple items for follow-up, and created issues for any items that are blocking migration (specifically, #203 and #205).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guides Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods"
Projects
None yet
Development

No branches or pull requests

3 participants