Review and address open TODOs in the guides

[christophermather]

A description of the work

This is part of step 1 in the 18F guide to migrating a guide.

As a part of preparing the remaining guides for migration, we need to go through and address all outstanding TODOs in the code. You can find these open TODOs by clicking this link.

You can also see all of these TODOs in this spreadsheet for ease of sorting.

Some stats:

• About a dozen TODOs are for replacement links to GitHub URLs (links to contributing files, new issue links, other repository links). These are changing because we've consolidated our repos into a new one. We'll need to identify the appropriate new URLs and swap them in for these TODOs.
• A whopping 36 of 57 TODOs are links to Methods. We can simply restore the original URLs here. We originally thought that we'd have new URLs before launch, but that won't be the case.
• Also, a whopping 44 of 57 TODOs are in the UX Guide (again, most of those are Methods links)
• Another 7 TODOs need a little research - they're either unclear (to me, a non-engineer) or broken external links.

Here's a little breakdown of TODOs by guide and recommend resolution:

Guide	Don't fix	Needs research	Replace URL	Restore URL	Grand Total
Accessibility		1	1		2
Brand			1		1
Content Guide			3		3
Engineering	1		2		3
Engineering Hiring			1		1
N/A		1			1
Product			1	1	2
UX Guide	1	5	3	35	44
Grand Total	2	7	12	36	57

Recommended steps
If it's possible to do a batch fix across all guides for Methods links, do that. That eliminates 36 TODOs right off the bat.

If not/then we should address the TODOs guide-by-guide. Here's the recommended order:

Should be easy:

1. Brand @melchoyce
2. Engineering Hiring @alexsobledotgov
3. Product @jskinne3
4. Engineering @alexsobledotgov
5. Content Guide @melchoyce

Needs a little attention
6. Accessibility @melchoyce

Might take some time
7. UX Guide @jskinne3 @melchoyce @alexsobledotgov (team effort!)

Note: the De-risking guide had no TODOs associated with it, so it is ready for #167

Order of operations

1. Pick which guide you're going to address and assign yourself above and in this spreadsheet
2. If it's unclear what link should be used, make a best guess and confirm w/ @echappen or @christophermather
3. Make changes in the markdown file
4. Make pull request and put issue "in review" in spreadsheet
5. @echappen reviews PR and approves
6. Mark it "done" in spreadsheet

Once all TODOs are done for a particular guide, let @christophermather and/or check it off in the below Tasks list.

Point of contact on this issue

@christophermather

Acceptance criteria

• A search of our code yields no outstanding TODOs

Tasks

Beta Give feedback

1. Brand guide TODOs are done
2. Engineering Hiring guide TODOs are done
3. Product guide TODOs are done
4. Engineering guide TODOs are done
5. Content guide TODOs are done
6. Accessibility guide TODOs are done
7. UX guide TODOs are done

[alexsobledotgov]

@christophermather Signing up to take TODOs on Engineering Hiring!

[alexsobledotgov]

@christophermather We think this may be done or very close! Great work from @melchoyce @jskinne3 👏 👏 👏

[christophermather]

TODOs = TODOne!