Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links resulting in a 404 error on guides.18f.gov #535

Closed
1 of 6 tasks
Tracked by #531
juliaklindpaintner opened this issue Apr 16, 2024 · 4 comments
Closed
1 of 6 tasks
Tracked by #531

Fix links resulting in a 404 error on guides.18f.gov #535

juliaklindpaintner opened this issue Apr 16, 2024 · 4 comments
Assignees
Labels
Guides Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods"

Comments

@juliaklindpaintner
Copy link
Member

juliaklindpaintner commented Apr 16, 2024

Contact Details

Julia Lindpaintner

What happened?

A sub-ticket of #531, this issue is to address the 404 errors identified by a scan of the guides.18f.gov website in March 2024.

Anticipated tasks:

  • Filter this spreadsheet in column H "Error code" by 404
  • Ignore any rows that have a comment in Column A — these either can be ignored since they are for the Methods site that will be deprecated soon or they have already been addressed by other tickets.
  • Identify the bad link and look for a replacement
  • If possible, replace. If not easily identified, recommend either removing or replacing with something similar.
  • As you address the links, add your resolution in column A — either link to the PR for the fix or note why couldn't fix it.

Version

1.0.2 (Default)

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@juliaklindpaintner juliaklindpaintner added Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods" Guides labels Apr 16, 2024
@juliaklindpaintner juliaklindpaintner changed the title Fix 404 links on guides.18f.gov Fix links resulting in a 404 error on guides.18f.gov Apr 16, 2024
@peterrowland peterrowland self-assigned this Apr 22, 2024
@peterrowland
Copy link
Member

235 of these are for the No Fear Act link in the footer, tracked in #532. Going to update the TLC resolution status for those rows to link to that issue.

A number of issues in the TLC resolution status column don't exist?

@juliaklindpaintner
Copy link
Member Author

@peterrowland Oh gosh, not sure how I managed that... I think I probably dragged down from the one GitHub issue and instead of repeating it, it successively added a number to each line. Correcting now... And yes, please ignore those 235 links that are tracked in #532.

@juliaklindpaintner
Copy link
Member Author

@peterrowland Okay I think I fixed it... It was probably the error I mentioned above plus the fact that it wasn't filtering including the TLC status column 🤦‍♀️ Anyway, I think it's okay now!

@peterrowland
Copy link
Member

Ah ok, thanks. Google sheets can't conceive of a reason you wouldn't want to iterate a number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guides Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods"
Projects
None yet
Development

No branches or pull requests

2 participants