Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 guide links #536

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Fix 404 guide links #536

merged 4 commits into from
Apr 17, 2024

Conversation

juliaklindpaintner
Copy link
Member

Changes proposed in this pull request:

security considerations

Content change only, no concerns

Current link results in 404; updating to the new location of this page on gsa.gov
Update two links, remove one
@juliaklindpaintner juliaklindpaintner requested review from amymok and a team as code owners April 16, 2024 20:18
Copy link
Member

@cantsin cantsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment LGTM

content/methods/fundamentals/privacy.md Outdated Show resolved Hide resolved
@cantsin
Copy link
Member

cantsin commented Apr 16, 2024

Thanks! LGTM -- now all we have to do is wait for the pa11y scan to finish ⏳

@juliaklindpaintner
Copy link
Member Author

Just caught one more broken link on the same page as the rest of the ADR links, so fixed that as well.

@juliaklindpaintner juliaklindpaintner merged commit 0619877 into main Apr 17, 2024
6 checks passed
@juliaklindpaintner juliaklindpaintner deleted the fix-404-guide-links branch April 17, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants