Replace pa11y with underlying HTML_CodeSniffer #285
Conversation
**Why**: - It currently duplicates and sometimes conflicts with our integration testing setup - Currently, we run two separate versions of Puppeteer, which each download separate copies of Chromium - Also helps me to avoid debugging a vague error occurring when upgrading dependencies to latest version - Consolidates testing tools to Jest - A step toward alignment of accessibility integration testing, as it could be reasonably substituted with aXe - Easier to run individual tests, which was difficult before since Jest setup occurred through scripts/jest.sh and did not support additional arguments. Now, test commands can go directly through the Jest CLI. - Fewer dependencies overall
| "test": "make test", | ||
| "test-pa11y": "make test-runner-pa11y", | ||
| "test-jest": "make test-runner-jest", | ||
| "build": "make build", |
There was a problem hiding this comment.
I guess I've never looked inside this file, but it seems very weird to me that the npm tasks call out to the Makefile... seems like most of the pipeline happens in JS except the jekyll build... make in a separate/future PR we can invert this?
There was a problem hiding this comment.
I guess I've never looked inside this file, but it seems very weird to me that the npm tasks call out to the Makefile... seems like most of the pipeline happens in JS except the jekyll build... make in a separate/future PR we can invert this?
Yeah, it's a bit nonconventional as things stand. Also means there is no make run like there is in other projects.
I feel like Makefile and npm scripts serve many of the same goals, so maybe we could just get rid of one or the other. 🤷
Why:
package-lock.json)Note that the intended result of these changes is an identical testing result to what existed previously, since
pa11y-ciwas already running HTML_CodeSniffer on our behalf. For additional context on HTML_CodeSniffer vs. aXe, see #203.