Override USWDS Sass packages at source #356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #336 to further restructure the folder structure to align to how files are managed in the upstream project.
Why?
pacakges/_uswds.scss
in sync as the upstream USWDS adds new components over time.Unfortunately the diff didn't turn out as clean as I'd hoped, despite the fact that 99% of changes are file renames.
Essentially, this converts:
Before:
After:
The same general principle of intercepting USWDS files applies, but now applies for both the top-level import (
@forward 'usa-accordion'
) as well as the package source (@forward 'usa-accordion/src/styles'
).The only meaningful code change here was to eliminate
$border-width
variable in some of the SCSS files. I was running into an error message that seemed to be caused by multiple forwarded modules each defining the variable. Unclear why this wasn't an issue previously 😬