Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript type-checking #407

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Add TypeScript type-checking #407

merged 4 commits into from
Feb 8, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Feb 7, 2024

🛠 Summary of changes

Adds TypeScript type-checking for existing JavaScript files.

As evidenced by the included changes, this helped highlight a couple legitimate issues:

  • The test for ensuring all components are exported was not working as intended, and therefore there were several components not being exported
  • The HTML_CodeSniffer test incorrectly assumed there would be an error argument passed in the callback, which doesn't exist

📜 Testing Plan

npm run typecheck

@aduth aduth marked this pull request as ready for review February 8, 2024 13:11
@aduth aduth merged commit 157da38 into main Feb 8, 2024
2 checks passed
@aduth aduth deleted the aduth-typescript branch February 8, 2024 13:14
@aduth aduth mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants