This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
Implement ProofAddress lambda (LG-3579) #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmargolis
requested review from
jmhooper,
mitchellhenke,
aduth,
solipet,
crissupb and
amathews-fs
zachmargolis
commented
Oct 1, 2020
| require File.expand_path(support) | ||
| end | ||
|
|
||
| Retries.sleep_enabled = false |
There was a problem hiding this comment.
This line is basically why I opted to use retries gem over Faraday's retrying -- I could not find any indication that Faraday would let us "cancel" sleeps in tests, so this lets us test our logic in specs without slowing them down or adding a lot of extra config logic
zachmargolis
commented
Oct 1, 2020
Comment on lines
+20
to
+25
| 'lexisnexis_account_id' => 'abc123', | ||
| 'lexisnexis_request_mode' => 'aaa', | ||
| 'lexisnexis_username' => 'aaa', | ||
| 'lexisnexis_password' => 'aaa', | ||
| 'lexisnexis_base_url' => 'https://lexisnexis.example.com/', | ||
| 'lexisnexis_phone_finder_workflow' => 'aaa', |
There was a problem hiding this comment.
definitely looking forward to a day when we can pass these all in to the gems as explicit params instead of relying on ENV vars
zachmargolis
changed the title
mitchellhenke
approved these changes
Oct 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I also scaffolded out a ProofResolution that I removed in 3d47d11, because I figure the structure of the two will match, so I wanted to get feedback on this approach first
The gist right now is:
Inputs to the lambda:
Lambda result (aka response):
POSTs to
$callback_urlwith a body like this (it'sProofer::Result#to_has JSON)headers:
X-API-AUTH-TOKEN: shared secret with IDP (may need to differ per env)body:
{ "address_result": { "success": true, "exception": null, "errors": {}, "messages": [] } }