-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-12317 add es and fr translations for please call email #10202
LG-12317 add es and fr translations for please call email #10202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svalexander I notice that in the screenshots there is no horizontal line separating the please do not reply text from the links at the bottom of the screen as there is in the design file. Is this a limitation of email display or are maybe our preview emails out of sync with the design, or is this just missing from the email view template?
@JackRyan1989 it seems to be a broader problem and will be addressed separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed French email subject line was updated to match Sprint306_TeamJoy_TranslationRequest.
I'd only suggested updating your branch with main before merging.
🎫 Ticket
Link to the relevant ticket:
LG-12317
🛠 Summary of changes
Added es and fr translation strings for please call email
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
es:
fr: