Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-12317 add es and fr translations for please call email #10202

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

svalexander
Copy link
Contributor

@svalexander svalexander commented Mar 5, 2024

🎫 Ticket

Link to the relevant ticket:
LG-12317

🛠 Summary of changes

Added es and fr translation strings for please call email

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Run locally
  • Open email preview
  • Choose "es" from the locale drop down and verify that translations have been updated
  • Choose "fr" from the locale drop down and verify that translations have been updated

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

es: Screen Shot 2024-03-22 at 12 11 12 PM
fr: Screen Shot 2024-04-15 at 4 44 40 PM

@svalexander svalexander requested review from a team, carmenrosalop, n1zyy and eileen-nava and removed request for a team and eileen-nava March 5, 2024 15:49
Copy link
Contributor

@JackRyan1989 JackRyan1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svalexander I notice that in the screenshots there is no horizontal line separating the please do not reply text from the links at the bottom of the screen as there is in the design file. Is this a limitation of email display or are maybe our preview emails out of sync with the design, or is this just missing from the email view template?

@gina-yamada
Copy link
Contributor

I confirmed that there is only 1 instances of each of the updated translations being used in templates. These updates will not affect other areas of the application accidentally. Nice work 👍

Screenshot 2024-03-05 at 9 05 59 AM Screenshot 2024-03-05 at 9 06 17 AM Screenshot 2024-03-05 at 9 22 22 AM

@carmenrosalop carmenrosalop requested review from allis-green and removed request for carmenrosalop March 5, 2024 19:23
@svalexander
Copy link
Contributor Author

@svalexander I notice that in the screenshots there is no horizontal line separating the please do not reply text from the links at the bottom of the screen as there is in the design file. Is this a limitation of email display or are maybe our preview emails out of sync with the design, or is this just missing from the email view template?

@JackRyan1989 it seems to be a broader problem and will be addressed separately

@svalexander svalexander marked this pull request as draft March 11, 2024 14:18
@svalexander svalexander marked this pull request as ready for review March 22, 2024 16:22
@gina-yamada gina-yamada self-requested a review April 16, 2024 15:26
Copy link

@rutvigupta-design rutvigupta-design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

Copy link
Contributor

@gina-yamada gina-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed French email subject line was updated to match Sprint306_TeamJoy_TranslationRequest.

I'd only suggested updating your branch with main before merging.

Screenshot 2024-04-16 at 9 25 44 AM

@svalexander svalexander merged commit 9025656 into main Apr 16, 2024
2 checks passed
@svalexander svalexander deleted the shannon/lg-12317-update-please-call-strings branch April 16, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants