Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor StepController into concern #1028

Merged
merged 1 commit into from Feb 3, 2017
Merged

Conversation

pkarman
Copy link
Contributor

@pkarman pkarman commented Feb 2, 2017

Why: Concerns are best.

Depends on #1016 to merge first. Review 1fddb0f only.

@monfresh
Copy link
Contributor

monfresh commented Feb 2, 2017

1016 is ready to go. Just needs to be squashed and merged.

@pkarman pkarman force-pushed the pek-step-controller-as-concern branch from 097e33e to 3bd4cf7 Compare February 3, 2017 17:41
@pkarman
Copy link
Contributor Author

pkarman commented Feb 3, 2017

@monfresh updated now that #1016 is merged, with specs that had been dropped in previous commit.

**Why**: Concerns are better than base class controllers.
@pkarman pkarman force-pushed the pek-step-controller-as-concern branch from 3bd4cf7 to 92daec5 Compare February 3, 2017 17:45
Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkarman pkarman merged commit e22e66e into master Feb 3, 2017
@pkarman pkarman deleted the pek-step-controller-as-concern branch February 3, 2017 18:12
amoose pushed a commit that referenced this pull request Mar 7, 2017
**Why**: Concerns are better than base class controllers.
amoose pushed a commit that referenced this pull request Mar 8, 2017
**Why**: Concerns are better than base class controllers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants