Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse config CSV values as CSV #10354

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Parse config CSV values as CSV #10354

merged 1 commit into from
Apr 3, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 3, 2024

馃洜 Summary of changes

Improves IdentityConfig converter for comma_separated_string_list to support CSV values embedding commas within double-quoted segments.

This is in response to a recent discovery that this was unsupported, which led to delays implementing a fix, and required a workaround in #10346 and patch deploy of RC 367.1. The changes included here could have avoided the need for that.

馃摐 Testing Plan

rspec spec/lib/identity_config_spec.rb

Validate compatibility of remaining uses of comma_separated_list_value:

  • requests_per_ip_cidr_allowlist
  • requests_per_ip_path_prefixes_allowlist
  • test_ssn_allowed_list

changelog: Internal, Configuration, Improve CSV parsing for configuration values
@aduth aduth requested a review from mitchellhenke April 3, 2024 13:58
@aduth aduth merged commit dcb4db3 into main Apr 3, 2024
2 checks passed
@aduth aduth deleted the aduth-identity-config-csv branch April 3, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants