Improve PIV CSP test assertion for order independence #10355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Automated Testing, Resolve flakey test failures for PIV CSP assertions
mitchellhenke
approved these changes
Apr 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洜 Summary of changes
Improve PIV CSP test assertion for order independence, to resolve a flakey test.
Example: https://gitlab.login.gov/lg/identity-idp/-/jobs/1114999
The issue is that the previous assertion assumed that the
form-actiondirective would never occur last and therefore always be suffixed with;. This doesn't appear to always be deterministic. The solution is to split the directives by the semi-colon joiner, which also preserves the expectation that theform-actionvalue only includes the asserted text.馃摐 Testing Plan