Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-12788: compare passwords compromised #10392

Merged
merged 32 commits into from
Apr 19, 2024

Conversation

mdiarra3
Copy link
Member

@mdiarra3 mdiarra3 commented Apr 9, 2024

🎫 Ticket

Link to the relevant ticket:
LG-12788

🛠 Summary of changes

Under a feature flag, allow users to be randomly selected and notified that hteir password is compromised.
The page is stubbed just getting initial workflow done.

@mdiarra3 mdiarra3 mentioned this pull request Apr 12, 2024
@mdiarra3 mdiarra3 marked this pull request as ready for review April 12, 2024 19:42
app/controllers/users/password_compromised_controller.rb Outdated Show resolved Hide resolved
db/schema.rb Outdated Show resolved Hide resolved
app/controllers/users/sessions_controller.rb Outdated Show resolved Hide resolved
app/controllers/application_controller.rb Outdated Show resolved Hide resolved
@mdiarra3 mdiarra3 requested a review from aduth April 17, 2024 15:34
@aduth aduth requested a review from a team April 18, 2024 11:51
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

app/controllers/users/sessions_controller.rb Outdated Show resolved Hide resolved
app/controllers/application_controller.rb Outdated Show resolved Hide resolved
@mdiarra3 mdiarra3 merged commit 48d6c9f into main Apr 19, 2024
2 checks passed
@mdiarra3 mdiarra3 deleted the LG-12788-compare-passwords-compromised branch April 19, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants