-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-12788: Migration #10425
Merged
Merged
LG-12788: Migration #10425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
approved these changes
Apr 15, 2024
db/primary_migrate/20240401185713_add_check_password_compromised_at_to_users.rb
Outdated
Show resolved
Hide resolved
aduth
reviewed
Apr 16, 2024
db/schema.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's changes we're missing in this file that need to be committed still, specifically the version
specifier in the define
call on line 13.
Applying the migration locally caused the following diff for me:
diff --git a/db/schema.rb b/db/schema.rb
index 0a2ff1e324..240bbd41a1 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.
-ActiveRecord::Schema[7.1].define(version: 2024_04_11_163520) do
+ActiveRecord::Schema[7.1].define(version: 2024_04_15_125124) do
# These are extensions that must be enabled in order to support this database
enable_extension "citext"
enable_extension "pg_stat_statements"
@@ -612,8 +611,8 @@ ActiveRecord::Schema[7.1].define(version: 2024_04_11_163520) do
t.string "encrypted_recovery_code_digest_multi_region"
t.datetime "second_mfa_reminder_dismissed_at"
t.datetime "piv_cac_recommended_dismissed_at"
- t.datetime "password_compromised_checked_at"
t.datetime "sign_in_new_device_at"
+ t.datetime "password_compromised_checked_at"
t.index ["reset_password_token"], name: "index_users_on_reset_password_token", unique: true
t.index ["sign_in_new_device_at"], name: "index_users_on_sign_in_new_device_at"
t.index ["uuid"], name: "index_users_on_uuid", unique: true
aduth
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12788
Migration for #10392