Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-13033: Reuse registration page for resending email confirmation #10404

Merged
merged 3 commits into from
Apr 11, 2024
Merged

LG-13033: Reuse registration page for resending email confirmation #10404

merged 3 commits into from
Apr 11, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 10, 2024

馃帿 Ticket

LG-13033

馃洜 Summary of changes

Removes the dedicated "Resend email confirmation" screen for new user email registration in favor of redirecting the user to the "Create an account" page. This simplifies the codebase, and resolves some inconsistencies in how we validate accepted rules of use.

馃摐 Testing Plan

  1. Go to http://localhost:3000/rails/mailers/user_mailer/email_confirmation_instructions
  2. Click "Confirm email address"
  3. Observe you are sent to the "Create an account" screen with an error message about invalid confirmation link
  4. Continue account creation
  5. Observe that after entering email and agreeing to Rules of Use, page submits successfully

馃憖 Screenshots

Before After
image image

@aduth
LG-13033: Reuse registration page for resending email confirmation
a376943 
changelog: Bug Fixes, Sign Up, Avoid prompting for Rules of Use on resent email confirmation
@aduth
Update spec helper to submit email registration page
98e237f
zachmargolis
zachmargolis approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big fan of the simplification!

app/controllers/concerns/unconfirmed_user_concern.rb Outdated Show resolved Hide resolved
app/forms/resend_email_confirmation_form.rb Show resolved Hide resolved
@aduth aduth merged commit e4b127c into main Apr 11, 2024
2 checks passed
@aduth aduth deleted the aduth-lg-13033-sign-up-email-resend branch April 11, 2024 12:20
@solipet solipet mentioned this pull request Apr 11, 2024
Merged
@aduth aduth mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmargolis zachmargolis zachmargolis approved these changes

@mitchellhenke mitchellhenke mitchellhenke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aduth @zachmargolis @mitchellhenke