LG-12757: Add a "cancel" confirmation step to “Connect your verified information to [Partner Agency]”

[jmdembe]

🎫 Ticket

Link to the relevant ticket:
LG-12757

🛠 Summary of changes

This pull request adds an interstitial page confirming if the user wants to exit the app to their service provider, or continue with setup

📜 Testing Plan

Required: OIDC app to simulate login through service provider

• Follow steps to create an account
• When prompted to select an authentication method, select only 1 method
• Complete steps to setup authentication method
• Select "Skip for now"
• Once on "Continue to Example Sinatra App", click "Cancel"
• Click "Exit Login.gov" on "Are you sure you want to cancel and Exit Login.gov" page
• Expect to be redirected to the service provider

👀 Screenshots

After:

English	Spanish	French

[aduth]

I see we have an existing SignUp::CancellationsController. Is that something we can reuse instead of adding a new controller?

[aduth]

Ah, I forgot that the SignUp::CancellationsController involves cancelling account creation altogether, i.e. destroying the new account. I don't think we'd want that for the consent screen. I'd wonder if we could at least preserve the naming convention of "cancel".

[jmdembe]

Preserving the 'cancel' convention makes sense.

[aduth]

I don't know that I'd expect these strings to live in account, since I believe those are otherwise for account dashboard pages. The completions page view and presenter use strings from a bunch of different places but it seems like sign_up might be the place for its own dedicated strings?

[jmdembe]

These strings were hard to place. This page is shown in two scenarios--when the user signs up and wishes to redirect and when the user signs in for the first time and does hits cancel and not "Agree and continue". I can see how it would fit in sign_up, but its not exclusive to the sign up process

[aduth]

Yeah I think it's a little strange as well and I might wonder if a new "completion(s)" section could work better, but we're already using sign_up for other strings on the page, and technically the controller is SignUp::CompletionsController so there's some precedent for sign-up, even if it's not strictly always how the user experiences it

[aduth]

Rather than embed the paragraph in the HTML, I'd expect it to be part of the view. But it looks like we already have a paragraph in the view markup as well, so we probably don't need it at all?

Suggested change

	header_html: <p>If you exit %{app_name} now:</p>
	header_html: If you exit %{app_name} now:

[aduth]

Based on previous conversation, I might suggest using "cancel" terminology instead of "exit" for consistency

[aduth]

We should probably not log this event until the user is actually redirected to the partner application. Currently it's being logged when they view the confirmation screen.

As mentioned when we were pairing, I'm wondering if it'd be better to create a separate controller/action and leave the redirect controller responsible only for redirecting, not for showing any user-facing views. That way, we can keep the analytics here but assume they'd only reach this action when it's time for them to be redirected.

[aduth]

We should probably not log this event until the user is actually redirected to the partner application. Currently it's being logged when they view the confirmation screen.

Additionally, we may want a separate logging event for when the user visits the confirmation screen.

[jmdembe]

That makes sense.

I remember at the very end of our pair session that we could try using a query parameter to redirect and that is why I explored that route. I'll go back to what we first talked about.

[aduth]

Functionally it's working well 👍 Noted a few lingering suggested adjustments.

[aduth]

A couple minor test-related comments, but otherwise LGTM! 👍