Document sign-in helper analytics events to unexempt extra analytics #10548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmargolis
approved these changes
May 2, 2024
| RSpec.feature 'Accessibility on static pages', :js, allowed_extra_analytics: [:*] do | ||
| RSpec.feature 'Accessibility on static pages', :js do |
There was a problem hiding this comment.
❤️ thanks for taking the time to do this!
It could have been that there have been other changes on It might be interesting to see if we can find a way to fail tests if |
… spec changelog: Internal, Documentation, Document additional analytics events properties
aduth
force-pushed
the
aduth-sign-in-analytics-exception
branch
from
1843786
to
dabf512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates a few analytics methods to specify and document the full set of expected arguments.
Specifically, this addresses issues stemming from shared helpers, where failing to document these may require additional new
allowed_extra_analyticsexceptions where ideally we'd want only the current set of exempted specs (i.e. exemptions only shrinking, never growing).Follow-up to discussion at #10405 (comment)
Temporarily merges to #10405, but will rebase tomainafter #10405 is merged.📜 Testing Plan
Verify that the build passes.