LG-12829: add conditional links for selfie help center articles #10415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let selfieHelpCenterLink = helpCenterLink; | ||
| let selfieHelpCenterLinkText = t('doc_auth.errors.general.selfie_failure_help_link_text'); | ||
| if (isFailedSelfieLivenessOrQuality) { | ||
| selfieHelpCenterLink += '#anchor' |
There was a problem hiding this comment.
WDYT of using a URL object to parse + manipulate this?
Suggested change
| selfieHelpCenterLink += '#anchor' | |
| const helpCenterURL = new URL(helpCenterLink) | |
| helpCenterURL.hash = 'anchor'; | |
| selfieHelpCenterLink = helpCenterURL.toString(); |
There was a problem hiding this comment.
We also have a similar abstraction addSearchParams. I could imagine abstracting a similar addHashAnchor or generalized addParams if we wanted to have a simple one-liner tool available, if we think this is a common pattern.
There was a problem hiding this comment.
Another thought, having this URL be an anchor is maybe just an implementation detail? What if both URLs were passed from the server as configs? Simplifies the frontend logic
amirbey
requested review from
a team,
charleyf and
dawei-nava
and removed request for
a team
amirbey
changed the title
changelog: Upcoming Features, Document Authentication, Add help center articles assisting user failing selfie match
amirbey
force-pushed
the
amirbey/LG-12829-selfie-help-center-articles
branch
from
eb3705e
to
70f69b1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帿 Ticket
Link to the relevant ticket:
LG-12829
馃洜 Summary of changes
Add a link to the error message that directs the user to the help center when selfie match fails.
馃摐 Testing Plan
馃憖 Screenshots
Liveness:
FaceMatch: