Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused usa-form styles #10418

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Remove unused usa-form styles #10418

merged 1 commit into from
Apr 12, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 12, 2024

馃洜 Summary of changes

Removes unused styles for the usa-form USWDS form component.

Despite having many forms, we never use the usa-form class. We do use usa-form-group styles, but these are included separately.

Performance Impact:

NODE_ENV=production yarn build:css && brotli-size app/assets/builds/application.css

Before: 18.7 kB
After 18.4 kB
Diff: -0.3 kB (-1.6%)

馃摐 Testing Plan

Verify there are no instances of usa-form class use in the codebase.

changelog: Internal, Performance, Reduce size of common application stylesheet
@aduth aduth merged commit b7d7b0e into main Apr 12, 2024
2 checks passed
@aduth aduth deleted the aduth-rm-usa-form-styles branch April 12, 2024 14:36
@mitchellhenke mitchellhenke mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants