Remove "fast" versions of setup and test tasks #10424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洜 Summary of changes
Removes "fast" alternatives to
make test
andmake setup
, i.e.make fast_test
andmake fast_setup
.As a substitute, added a new paragraph to README.md encouraging running tests for individual files and folders.
Why?
fast_setup
, it's unclear that it actually works, and has likely fallen out of sync withbin/setup
fast_test
, while this may have been helpful when accessibility tests were some of the only tests using ChromeDriver, there is now many more tests using the headless browser and therefore "fast_test" is not really very fast anyways.馃摐 Testing Plan
Verify
make fast_test
andmake fast_setup
error due to removed task code.