Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "fast" versions of setup and test tasks #10424

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 12, 2024

馃洜 Summary of changes

Removes "fast" alternatives to make test and make setup, i.e. make fast_test and make fast_setup.

As a substitute, added a new paragraph to README.md encouraging running tests for individual files and folders.

Why?

  • In both cases, it's unclear that they're actively used and useful
  • In the case of fast_setup, it's unclear that it actually works, and has likely fallen out of sync with bin/setup
  • In the case of fast_test, while this may have been helpful when accessibility tests were some of the only tests using ChromeDriver, there is now many more tests using the headless browser and therefore "fast_test" is not really very fast anyways.

馃摐 Testing Plan

Verify make fast_test and make fast_setup error due to removed task code.

changelog: Internal, Local Development, Remove "fast" versions of setup and test tasks
@aduth aduth merged commit 6c78ba9 into main Apr 12, 2024
2 checks passed
@aduth aduth deleted the aduth-rm-fast-test-setup branch April 12, 2024 18:02
@mitchellhenke mitchellhenke mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants