Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstall Express dependencies for webpack-dev-server advisory #10430

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 15, 2024

馃洜 Summary of changes

Updates resolved versions of express and follow-redirects to resolve outstanding security advisories, as transitive dependencies of webpack-dev-server.

This was meant to be addressed in #10350, but the updated version of webpack-dev-server did not require a minimum version of express and follow-redirects to resolve the advisory.

The process for performing this update was to manually remove top-level entries of express and follow-redirects from yarn.lock and running yarn install to allow the latest version of the dependencies that satisfies the version constraints of their ancestor dependency (webpack-dev-server). This is something that a tool like npm audit fix would automate for us, but an equivalent tool does not exist in Yarn Classic.

馃摐 Testing Plan

Verify no errors or changes to yarn.lock after running yarn install (this is also verified through CI):

yarn install

Verify that yarn audit is empty after yarn install.

changelog: Internal, Dependencies, Update dependencies to resolve security advisories
@aduth aduth merged commit 9791a2d into main Apr 15, 2024
2 checks passed
@aduth aduth deleted the aduth-webpack-dev-express branch April 15, 2024 14:06
@mitchellhenke mitchellhenke mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants