Reinstall Express dependencies for webpack-dev-server advisory #10430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洜 Summary of changes
Updates resolved versions of
express
andfollow-redirects
to resolve outstanding security advisories, as transitive dependencies ofwebpack-dev-server
.This was meant to be addressed in #10350, but the updated version of
webpack-dev-server
did not require a minimum version ofexpress
andfollow-redirects
to resolve the advisory.The process for performing this update was to manually remove top-level entries of
express
andfollow-redirects
fromyarn.lock
and runningyarn install
to allow the latest version of the dependencies that satisfies the version constraints of their ancestor dependency (webpack-dev-server
). This is something that a tool likenpm audit fix
would automate for us, but an equivalent tool does not exist in Yarn Classic.馃摐 Testing Plan
Verify no errors or changes to
yarn.lock
after runningyarn install
(this is also verified through CI):Verify that
yarn audit
is empty afteryarn install
.