Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user remember_created_at as ignored column #10431

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Add user remember_created_at as ignored column #10431

merged 1 commit into from
Apr 15, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 15, 2024

馃洜 Summary of changes

Marks remember_created_at on the User model as ignored, as a prerequisite to removing the column in #10429.

See: #10429 (review)

馃摐 Testing Plan

Verify that selecting all fields from a user does not produce a query including remember_created_at:

$ rails c
> User.first
# Observe that the logged SQL query does not include `remember_created_at`

@aduth
Add user remember_created_at as ignored column
60f7676 
changelog: Internal, Database, Remove unused column from users table
@aduth aduth merged commit 616d770 into main Apr 15, 2024
2 checks passed
@aduth aduth deleted the aduth-users-remember-created-at-ignore branch April 15, 2024 14:10
@mitchellhenke mitchellhenke mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmargolis zachmargolis zachmargolis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aduth @zachmargolis