LG-13025 - ThreatMetrix check should fail if we don't have a ThreatMetrix session id. #10452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `VerifyInfoController` event logging includes the client - If we don't have a TM session id, return a unique client name - If we don't have PII to send to TM, return a unique client name - Continue to return the same client name if TM is disabled. We used to return the same client name for all three conditions. changelog: Internal,analytics and IdV,Improved handling and logging for ThreatMetrix requests.
jmax-gsa
force-pushed
the
jmax/LG-13025-users-should-fail-proofing-without-threatmetrix-id
branch
from
de51dc2
to
16419cf
Compare
matthinz
reviewed
Apr 18, 2024
matthinz
reviewed
Apr 18, 2024
| def threatmetrix_pii_missing_result | ||
| Proofing::DdpResult.new( | ||
| success: false, | ||
| client: 'tmx_pii_missing', |
There was a problem hiding this comment.
Note to other reviewers: abusing the client field for these kind of statuses is not ideal, but it is a pattern that is established in the codebase and not something we're looking to solve in this PR.
jmax-gsa
force-pushed
the
jmax/LG-13025-users-should-fail-proofing-without-threatmetrix-id
branch
from
f89b60f
to
bf462e9
Compare
matthinz
reviewed
Apr 18, 2024
Changed the error return slightly.
matthinz
approved these changes
Apr 23, 2024
Spec cleanup. Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
jmax-gsa
deleted the
jmax/LG-13025-users-should-fail-proofing-without-threatmetrix-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.