Fix flash of accordion content during page load #10458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洜 Summary of changes
This updates Accordion component markup, removing invalid
usa-accordion__container
wrapper element, in order to allow the intended improvement from@18f/identity-design-system@9.1.0
to prevent flashing content during page load.This follows a similar change from the introduction of that enhancement in 18F/identity-design-system#434 to alter the documented component markup, "[removing] an unnecessary and useless
usa-accordion__container
container element which is not standard to USWDS and would make the JavaScript hiding behavior ineffective".馃摐 Testing Plan
馃憖 Screenshots
Screen recordings emulating slower page loads with "Fast 3G" preset in Chrome network simulation..
Before:
before.mov
After:
after.mov