LG-12999: Fix Selfie Inline Error #10513
Conversation
| @@ -86,8 +86,7 @@ en: | |||
| network_error: We are having technical difficulties on our end. Please try to | |||
| submit your images again later. | |||
| no_liveness: Try taking new pictures. | |||
| selfie_failure: Try taking your photos again. Make sure all of your photos are | |||
| clear and in focus. | |||
| selfie_failure: We couldn’t verify the photo of yourself. Try taking a new picture. | |||
There was a problem hiding this comment.
@kellular (or anyone) I'm not seeing translations? I'll keep looking.
There was a problem hiding this comment.
@charleyf They might have been accidentally removed the last time we worked on this in-line error, I can't recall. But here are the DOS translations:
Spanish: No pudimos verificar su foto. Intente tomar una nueva foto.
French: Nous n’avons pas pu vérifier votre photo. Essayez de prendre une nouvelle photo.
Chinese Simplified (are we supposed to add these now?): 我们无法验证你自己的照片。请重拍一张。
There was a problem hiding this comment.
Thanks! Added those, I don't see anywhere to put the simplified Chinese yet. I would expect a file like doc_auth/zh-CN.yml.
There was a problem hiding this comment.
@charleyf , it's zh.yml.
There was a problem hiding this comment.
@kellular yes, please include Chinese translations going forward
There was a problem hiding this comment.
Added the chinese translation
There was a problem hiding this comment.
@charleyf thanks for adding the chinese translation - could you please add a screenshot to the PR so I can submit this for DOS LQA approval?
There was a problem hiding this comment.
Uploaded a screenshot to the PR description.
charleyf
requested review from
a team,
amirbey and
night-jellyfish
and removed request for
a team
charleyf
deleted the
charley/lg-12999-fix-inline-errors-for-various-scenarios
branch
|
I would have waited a little longer, but Amir needs these tests for something he's working on. |
* Change inline error * changelog: User-Facing Improvements, Selfie, Fix inline error text above selfie box * Remove unusual line terminators (auto detected by VS Code) * Change translations too * Lint fix * Add chinese translation * Remove newly translated key from exception list * Add tests for inline selfie errors * Lint fixes * Fix space (remove b/c odd whitespace character)
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-12999
🛠 Summary of changes
This PR changes the text that appears over the selfie field to be the text we want.
📜 Testing Plan
Get a selfie failure, verify that the red inline error text over the selfie box is "We couldn’t verify the photo of yourself. Try taking a new picture."