Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser gem to 6.0.0 #10535

Merged
merged 1 commit into from
May 1, 2024
Merged

Update browser gem to 6.0.0 #10535

merged 1 commit into from
May 1, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented May 1, 2024

馃洜 Summary of changes

Updates browser gem to v6.0.0.

This adds support for a chromium_based? method which could be useful for our browser support detection. I requested this via fnando/browser#541 with the intention of using it, though I can't recall exactly what I had planned to use it for.

Regardless, there seems to be some nice potential performance optimizations here that we could take advantage of in the meantime.

Notable code improvements are:

馃摐 Testing Plan

Build should pass.

changelog: Internal, Dependencies, Update dependencies to latest versions
@zachmargolis
Copy link
Contributor

This adds support for a chromium_based? method which could be useful for our browser support detection. I requested this via fnando/browser#541 with the intention of using it, though I can't recall exactly what I had planned to use it for.

Was it for Passkey support?

@aduth
Copy link
Member Author

aduth commented May 1, 2024

This adds support for a chromium_based? method which could be useful for our browser support detection. I requested this via fnando/browser#541 with the intention of using it, though I can't recall exactly what I had planned to use it for.

Was it for Passkey support?

Nothing springs to mind on mention of it 馃し I'm sorta thinking it's something with all the edge-cases we've had to deal with in BrowserSupport, things like embedded webviews, Chrome-on-iOS-is-actually-Safari, etc.

@aduth aduth merged commit c913258 into main May 1, 2024
2 checks passed
@aduth aduth deleted the aduth-browser-6 branch May 1, 2024 17:01
samathad2023 pushed a commit that referenced this pull request May 11, 2024
changelog: Internal, Dependencies, Update dependencies to latest versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants