Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洜 Summary of changes
Updates
browser
gem to v6.0.0.This adds support for a
chromium_based?
method which could be useful for our browser support detection. I requested this via fnando/browser#541 with the intention of using it, though I can't recall exactly what I had planned to use it for.Regardless, there seems to be some nice potential performance optimizations here that we could take advantage of in the meantime.
Notable code improvements are:
instance_of?
vs. creating new instances when detecting browsers馃摐 Testing Plan
Build should pass.