Require 2FA for admin to access constrained route #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfresh
force-pushed
the
require-2fa-for-sidekiq-access
branch
from
df3b9db
to
ac42aa8
Compare
|
code lgtm. The travis errors are about Redis, which I assume is because the route is succeeding and the sidekiq initialization is being invoked. Maybe need to mock that better? |
|
Weird. It passes locally when Redis is not running. I'll try in Docker. |
|
@amoose Feel free to take over. I won't have time to address this before I leave. Thanks! |
**Why**: To better protect access to dashboards such as Sidekiq and Split.
pkarman
force-pushed
the
require-2fa-for-sidekiq-access
branch
from
e52e3b0
to
20eb85a
Compare
|
I enabled the redis service at travis ci and that got the tests passing again. I'm not sure why it is suddenly needed, as like @monfresh it works for me locally in test with redis not running. |
|
I'm +1 to merge unless there is some specific reason we don't want redis running at travis ci. |
|
We will need to enable it for #474 anyhow, so I think it's OK. I want to try one more test then will give green light. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: To better protect access to dashboards such as Sidekiq and
Split.