Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-3839 Change SSN and mailing address #5144

Merged
merged 11 commits into from Jun 22, 2021
Merged

LG-3839 Change SSN and mailing address #5144

merged 11 commits into from Jun 22, 2021

Conversation

stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Jun 14, 2021 •
edited

.

@stevegsa stevegsa marked this pull request as ready for review June 14, 2021 18:24
@stevegsa
Copy link
Contributor Author

Screenshots:

Screen Shot 2021-06-16 at 11 28 07 PM

Screen Shot 2021-06-16 at 11 27 22 PM

aduth
aduth approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from code point-of-view 👍

anniehirshman-gsa
anniehirshman-gsa reviewed Jun 21, 2021
View reviewed changes
Copy link
Contributor

@anniehirshman-gsa anniehirshman-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevegsa thanks for sharing the screenshots! Just a couple small questions/asks:

  1. The text content for the SSN step hasn't been implemented on the main page yet (it's ticketed in LG-4502), but I do think the two pages should match. Would it be easy to add that text to the initial "Please enter your Social Security number" page as well?
  2. Tiny content issue: could you update Social Security number so both S's are capitalized and number is lowercase? (Bonus win if you're able to fix the "Please enter your Social Security number" page as well!)
  3. Last thing - could you please post a screenshot of the changes to the "Update your mailing address" page?

Thanks so much!!

@stevegsa
Copy link
Contributor Author

New screenshots:
Screen Shot 2021-06-21 at 4 17 22 PM

Screen Shot 2021-06-21 at 4 17 45 PM

Screen Shot 2021-06-21 at 4 19 28 PM

@stevegsa stevegsa merged commit d341be4 into main Jun 22, 2021
@stevegsa stevegsa deleted the stevegsa-change-ssn-and-mailing-address-updates branch June 22, 2021 03:18
mitchellhenke pushed a commit that referenced this pull request Jul 22, 2021
@stevegsa @mitchellhenke
LG-3839 Change SSN and mailing address (#5144)
9279e04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anniehirshman-gsa anniehirshman-gsa anniehirshman-gsa left review comments

@aduth aduth aduth approved these changes

Assignees
No one assigned
Labels
status - ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevegsa @aduth @anniehirshman-gsa